Upgrade rand crate dependency to 0.7#91
Merged
Merged
Conversation
Contributor
Author
|
This PR is best reviewed by-commit. I migrated via intermediate |
str4d
force-pushed
the
upgrade-rand
branch
2 times, most recently
from
79c66d2 to
eecef7d
Compare
This removes rand < 0.5 from our Cargo.lock.
daira
approved these changes
Jul 26, 2019
daira
left a comment
daira
left a comment
Contributor
There was a problem hiding this comment.
utACK. A couple of minor comment suggestions.
Co-Authored-By: Daira Hopwood <daira@jacaranda.org>
ebfull
approved these changes
Jul 26, 2019
ebfull
left a comment
ebfull
left a comment
Collaborator
There was a problem hiding this comment.
This is an incredible PR, well done.
Merged
This was referenced Aug 5, 2019
Closed
str4d
added a commit
to str4d/librustzcash
that referenced
this pull request
Oct 8, 2019
They were broken by zcash#91 but went unnoticed because CI does not compile the benchmarks, which requires the nightly toolchain.
ebfull
pushed a commit
to ebfull/librustzcash
that referenced
this pull request
Mar 4, 2020
They were broken by zcash#91 but went unnoticed because CI does not compile the benchmarks, which requires the nightly toolchain.
greg0x
pushed a commit
to valargroup/librustzcash
that referenced
this pull request
Mar 12, 2026
refactor: progress to confirmed if 2/3 have acked after timeout
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also moves to
rand_corewhere possible, to reduce the dependency surface.Closes #60.